Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 5, 2025


PR-Codex overview

This PR focuses on enhancing the UI of the invoice settings page by replacing Card components with a more straightforward layout using div elements, updating badge styles, and improving pagination controls in the BillingHistory component.

Detailed summary

  • Replaced Card components with div elements in page.tsx.
  • Updated invoice title and description styling.
  • Changed badge styles for invoice statuses in BillingHistory.
  • Introduced TableContainer for improved table layout.
  • Enhanced pagination controls with better styling and structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 1:59pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 5, 2025 1:59pm
login ⬜️ Skipped (Inspect) Apr 5, 2025 1:59pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 5, 2025 1:59pm
wallet-ui ⬜️ Skipped (Inspect) Apr 5, 2025 1:59pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 13:03 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 13:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 13:03 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 13:03 Inactive
@MananTank MananTank marked this pull request as ready for review April 5, 2025 13:03
@MananTank MananTank requested review from a team as code owners April 5, 2025 13:03
Copy link
Member Author

MananTank commented Apr 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 5, 2025
@codecov
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (309d1d5) to head (386138e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6660   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files         889      889           
  Lines       55858    55858           
  Branches     3822     3822           
=======================================
  Hits        30751    30751           
  Misses      25012    25012           
  Partials       95       95           
Flag Coverage Δ
packages 55.05% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.57 KB (0%) 952 ms (0%) 164 ms (+91.25% 🔺) 1.2 s
thirdweb (cjs) 129.95 KB (0%) 2.6 s (0%) 259 ms (+4.71% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 75 ms (+749.89% 🔺) 188 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 45 ms (+2271.96% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 95 ms (+427.7% 🔺) 483 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 5, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the rendering of the invoice history page and improving the `BillingHistory` component's layout and functionality, including UI updates and pagination controls.

### Detailed summary
- Replaced `Card` components with a `div` structure for the invoice history.
- Updated headings and descriptions with new styling.
- Changed badge components for invoice statuses to use variants.
- Refined pagination controls with improved styling and layout.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-05-dashboard_team_invoices_page_style_tweaks branch from e5ad4e1 to 386138e Compare April 5, 2025 13:53
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: 386138e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app graphite-app bot merged commit 386138e into main Apr 5, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 04-05-dashboard_team_invoices_page_style_tweaks branch April 5, 2025 14:00
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 5, 2025 14:00 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 5, 2025 14:00 Inactive
@vercel vercel bot temporarily deployed to Production – login April 5, 2025 14:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants